Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export KO_FLAGS for consuming scripts #401

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Export KO_FLAGS for consuming scripts #401

merged 1 commit into from
Oct 25, 2024

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Oct 23, 2024 •
edited
Loading

Changes

  • Export KO_FLAGS for consuming scripts

Per the Slack thread with Vincent. If you prefer to do it globally. Otherwise we could also isolate the changes as needed into consuming ${knative-repo}/hack/release.sh.

/cc @dprotaso @upodroid @cardil

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2024
cardil
cardil approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I have no problems with exporting this

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsimansk
Copy link
Contributor Author

/hold for others to chime in

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2024
@dsimansk
Copy link
Contributor Author

/cherry-pick release-1.16

@knative-prow-robot
Copy link

@dsimansk: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@houshengbo
Copy link

/lgtm

@dsimansk
Copy link
Contributor Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 25, 2024
@knative-prow knative-prow bot merged commit ef6e7e9 into knative:main Oct 25, 2024
6 checks passed
@knative-prow-robot
Copy link

@dsimansk: new pull request created: #402

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cardil cardil cardil approved these changes

@dprotaso dprotaso Awaiting requested review from dprotaso

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@cardil cardil

@houshengbo houshengbo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsimansk @knative-prow-robot @houshengbo @cardil